[RHDHBUGS-3010]: Fix GitHub publication workflow (release-1.9)#2101
Merged
themr0c merged 10 commits intoApr 27, 2026
Conversation
…ode.js Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
The rsync on line 148 already copies the entire build/scripts directory including cqa/. The subsequent rm + cp of the same cqa/ directory was a leftover from before rsync was used. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Legacy utility script with no references from any workflow, script, or documentation. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
build-cqa.sh: thin wrapper for node cqa/index.js --all, never referenced by any workflow or script. lint-scripts.sh: local shellcheck runner superseded by the shellcheck.yml workflow using reviewdog. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Collaborator
Shellcheck Analysis ResultsNo shell scripts were changed in this PR. Automated shellcheck analysis • See shellcheck.net for details |
Collaborator
PR Build ResultsBuild failed -- 34/34 titles | 129s Content Quality AssessmentCQA Report
SummaryChecks: 19 total, 19 pass, 0 fail 19 checks: 19 pass, 0 fail Run Updated 2026-04-24 15:22:42 UTC |
themr0c
force-pushed
the
fix/gh-pages-workflow-1.9
branch
from
536adff to
b9475a0
Compare
themr0c
force-pushed
the
fix/gh-pages-workflow-1.9
branch
from
b9475a0 to
7674fa6
Compare
themr0c
force-pushed
the
fix/gh-pages-workflow-1.9
branch
from
7674fa6 to
9349c91
Compare
Shellcheck: filter out deleted .sh files before running shellcheck, preventing reviewdog parse error on empty input. SonarCloud: use http.extraHeader for git auth instead of embedding token in remote URL, avoiding security hotspot. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
themr0c
force-pushed
the
fix/gh-pages-workflow-1.9
branch
from
9349c91 to
67e2882
Compare
- Add --no-cqa and --no-lychee flags to build-orchestrator.js - Use --no-cqa in build-asciidoc.yml (CQA results not surfaced in branch builds) - Fix CQA-14 hardcoded '-b main': detect current branch from git - CQA-14 standalone now passes --no-cqa to avoid redundant CQA run Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
- Replace node:https callback API with fetch() (Node 18+) - Remove unused branchDir parameter from applyContent() - Extract cleanup from stageAndCommit into pushWithRetry (runs once, not per retry) - Deduplicate readdirSync call for diagnostics - Add flow overview and inline comments for non-obvious decisions Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
The Node.js rewrite was 325 lines for functionality that fits naturally in ~289 lines of bash. The deploy script's core job is git operations (fetch, copy, add, commit, push) which read more naturally in shell. Changes from the original 88-line script: - Rebase-based retry replaces sleep-based retry (instant vs 2+ minutes) - Cleanup of stale PR/branch dirs integrated (was separate workflow step) - Index regeneration integrated (was in build-orchestrator.js) - Token auth via http.extraHeader (was in remote URL, leaked in logs) Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Keep the original CLI style: deploy-gh-pages.sh <publish_dir> [--message <msg>] Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
IMPORTANT: Do Not Merge - To be merged by Docs Team Only
Version(s): 1.9
Issue: https://redhat.atlassian.net/browse/RHDHBUGS-3010
Preview: N/A (workflow and build script changes)
Summary
Cherry-pick of scripts + workflow changes from the main PR (/pull/2100). Merge this first.
main/on gh-pages (preliminary report +CQA_RUNNINGguard)deploy-gh-pages.shas Node.js (deploy-gh-pages.js) with integrated cleanup, index regeneration, and rebase retrypr.ymlbuild.sh,build-cqa.sh,lint-scripts.shTest plan
pr-N/(notmain/) on gh-pages🤖 Generated with Claude Code
Co-Authored-By: Claude Opus 4.6 noreply@anthropic.com